feat: query parser: add types for count
#498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 1, 2024
bnjmnt4n
force-pushed
the
query-parser/count
branch
from
82d1548
to
abc844e
Compare
bnjmnt4n
force-pushed
the
query-parser/count
branch
from
abc844e
to
178049e
Compare
bnjmnt4n
force-pushed
the
query-parser/count
branch
from
178049e
to
ae44c2d
Compare
steve-chavez
approved these changes
Mar 3, 2024
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
The types for select queries do not have types for
countsince it is not a column of the table.What is the new behavior?
Types for
countare added to all tables, since it is an aggregate which supported by PostgREST and is widely used in the Supabase-js documentation as well.Additional context
This PR is stacked on top of #497.
Closes #447, #479.
I'm not sure if the handling of the cardinality is correct for this.